lua cluster_specifier: give access to cluster connection/request counts #36998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Greg Greenway <ggreenway@apple.com>
wbpcode
approved these changes
Nov 6, 2024
ggreenway
added a commit
to ggreenway/envoy
that referenced
this pull request
Nov 8, 2024
Envoy would crash when the Lua garbage collector ran if `getCluster()` had been called. This was added in envoyproxy#36998 Signed-off-by: Greg Greenway <ggreenway@apple.com>
wbpcode
pushed a commit
that referenced
this pull request
Nov 9, 2024
Envoy would crash when the Lua garbage collector ran if `getCluster()` had been called. This was added in #36998 Signed-off-by: Greg Greenway <ggreenway@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add accessors from a cluster_specifier lua script for cluster connection and request counts
Risk Level: Low
Testing: New tests added
Docs Changes: Added
Release Notes: Added